Freescale fec.c driver breakage

On 04/06/12 19:16, Mark Brown wrote:

On Mon, Jun 04, 2012 at 10:19:37AM +0200, Sascha Hauer wrote:

quoted

On Mon, Jun 04, 2012 at 02:42:28PM +1000, Greg Ungerer wrote:

quoted

quoted

Trivially we could conditionalize the code block that calls
devm_clk_get() in the probe routine, but that is kind of ugly.

quoted

It's ugly, but the only other solution I see is that you could provide a
dummy devm_clk_get() for coldfire. Added Mark to Cc, maybe he has
another idea?

Not really, I think if the clock API is going to be usable we really
need the platforms to all be implementing it.  Part of this is getting
the stubs for !HAVE_CLK cases implemented (which doesn't seem to have
happened :/) ).  We do need to address this at the framework level,
having to put ifdefs in all the drivers is obviously awful.

Is this something you intend "fixing" then?

I don't mind putting a simplistic (but do nothing) place holder for
this function along with the other stubbed clk functions in the m68k/
coldfire code.

But more generally I am wondering does it make sense to be working
on specific platform clocks in a multi-platform/arch driver?

Regards
Greg


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com