[PATCH v10] MTD: LPC32xx MLC NAND driver
From: Roland Stigge <hidden>
Date: 2012-06-30 12:32:22
Also in:
linux-devicetree, lkml
Hi Artem! Thanks for the notes! On 29/06/12 14:37, Artem Bityutskiy wrote:
quoted hunk ↗ jump to hunk
Successfully built configuration "arm-lpc32xx_defconfig,arm,arm-unknown-linux-gnueabi-", results:--- before_patching.log +++ after_patching.log @@ @@ +drivers/mtd/nand/lpc32xx_mlc.c: In function 'lpc32xx_nand_probe': +drivers/mtd/nand/lpc32xx_mlc.c:679:10: warning: variable 'sr' setbut not used [-Wunused-but-set-variable] +drivers/mtd/nand/lpc32xx_mlc.c:561:24: error: bad constant expression [sparse]
This is because sparse doesn't understand this local variable: uint8_t buf[mtd->writesize]; (but gcc does). Are you sure we need to support sparse? The above construction is quite convenient for this case and I'd prefer this to allocating another buffer dynamically. Thanks in advance, Roland