[PATCH v10] MTD: LPC32xx MLC NAND driver
From: Alexandre Pereira da Silva <hidden>
Date: 2012-06-29 12:56:41
Also in:
linux-devicetree, lkml
On Fri, Jun 29, 2012 at 9:37 AM, Artem Bityutskiy [off-list ref] wrote:
quoted hunk ↗ jump to hunk
On Wed, 2012-06-27 at 23:55 +0200, Roland Stigge wrote:quoted
This patch adds a driver for the MLC NAND controller of the LPC32xx SoC. Signed-off-by: Roland Stigge <redacted> Signed-off-by: Alexandre Pereira da Silva <redacted> ---Aiaiai complains like this about your patch, please, take a look: -------------------------------------------------------------------------------- Successfully built configuration "arm-lpc32xx_defconfig,arm,arm-unknown-linux-gnueabi-", results:--- before_patching.log +++ after_patching.log@@ @@ +drivers/mtd/nand/lpc32xx_mlc.c: In function 'lpc32xx_nand_probe': +drivers/mtd/nand/lpc32xx_mlc.c:679:10: warning: variable 'sr' set but not used [-Wunused-but-set-variable] +drivers/mtd/nand/lpc32xx_mlc.c:561:24: error: bad constant expression [sparse]
This build fine here, with gcc 4.5.3 Which gcc version is he using?
-------------------------------------------------------------------------------- checkpatch.pl has some complaints: -------------------------------------------------------------------------------- checkpatch.pl results for patch "[PATCH] MTD: LPC32xx MLC NAND driver" ERROR:INITIALISED_STATIC: do not initialise statics to 0 or NULL #339: FILE: drivers/mtd/nand/lpc32xx_mlc.c:224: +static int use_dma = 0; total: 1 errors, 0 warnings, 1004 lines checked -------------------------------------------------------------------------------- -- Best Regards, Artem Bityutskiy