On 16/06/12 19:23, Arnd Bergmann wrote:

On Saturday 16 June 2012, Roland Stigge wrote:

quoted

+       if (of_get_property(np, "wp-gpios", NULL)) {
+               pdata->gpio_wp = of_get_named_gpio(np, "wp-gpios", 0);
+               if (pdata->gpio_wp == -ENODEV)
+                       pdata->gpio_wp = -EPROBE_DEFER;
+       } else {
+               pdata->gpio_wp = -ENODEV;
+       }

This is still very ugly and there is a certain danfer that we might
have to duplicate this across more drivers. Can't we make
of_get_named_gpio_flags return -EPROBE_DEFER in cases where we can't
find the GPIO number yet but still have a chance of returning it at
a later point?

OK, will post a new patch.

Roland