Thread (3 messages) 3 messages, 2 authors, 2012-06-16

[PATCH v2] mmc: mmci.c: Defer probe() in case of yet uninitialized GPIOs

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-06-16 17:23:42
Also in: linux-mmc, lkml

On Saturday 16 June 2012, Roland Stigge wrote:
+       if (of_get_property(np, "wp-gpios", NULL)) {
+               pdata->gpio_wp = of_get_named_gpio(np, "wp-gpios", 0);
+               if (pdata->gpio_wp == -ENODEV)
+                       pdata->gpio_wp = -EPROBE_DEFER;
+       } else {
+               pdata->gpio_wp = -ENODEV;
+       }
This is still very ugly and there is a certain danfer that we might
have to duplicate this across more drivers. Can't we make
of_get_named_gpio_flags return -EPROBE_DEFER in cases where we can't
find the GPIO number yet but still have a chance of returning it at
a later point?

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help