On Mon, May 14, 2012 at 04:49:21PM +0100, Lee Jones wrote:

quoted

You should be using of_regulator_match() for this (I think it's supposed
to do an equivalent job...) rather than open coding.

I've ripped this out completely and the code appears to continue be
fully functional. Happy days! :)

Great!

The original driver places each of the registers inside a structure
within the driver itself and recursively registers them from there.
The constraints are united with the correct element using #defines.

Can't we just assume that all of the regulators will be put into the
Device Tree? As this is what I'll be doing.

Part of the idea here is to help with diagnostics, especially during
board bringup, so we really shouldn't be relying on the user to have set
things up reliably.  This is also used to enabled features like powering
off any unused regulators that were left enabled in late init so things
that weren't set up turn out to be moderately important.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120514/cccade9e/attachment.sig>