Thread (73 messages) 73 messages, 5 authors, 2012-06-29

[PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree

From: Lee Jones <hidden>
Date: 2012-05-31 00:42:19
Also in: lkml

On 31/05/12 00:41, Mark Brown wrote:
On Wed, May 30, 2012 at 11:22:33PM +0800, Lee Jones wrote:
quoted
On 30/05/12 23:11, Mark Brown wrote:
quoted
quoted
quoted
	vin-supply =<&db8500_vape_reg>;
	vmmc-supply =<&ab8500_ldo_aux2_reg>;
quoted
quoted
Oh, oops.  This is going to be fun when someone puts down two of the
same PMIC on a system...
quoted
What does that mean sorry?
Lots of regulators are using this mechanism for identifying child nodes.
If the node name is also used as a handle by other things to reference
the regulator then if you have two PMICs of the same type DTC isn't
going to be able to figure out which node you mean.
I haven't looked at the code yet, so I don't know the answer to this 
question, but; aren't they protected by the compatible string? If not, I 
think they should be. We shouldn't be parsing other platform's Device Trees.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help