Thread (73 messages) 73 messages, 5 authors, 2012-06-29

[PATCH 16/22] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ

From: Linus Walleij <hidden>
Date: 2012-05-30 07:10:30
Also in: lkml

On Wed, May 30, 2012 at 12:47 PM, Lee Jones [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.

Cc: Samuel Ortiz <redacted>
Cc: linux-kernel at vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
?drivers/mfd/ab8500-gpadc.c | ? ?3 ++-
?1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index c39fc71..358d502 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -599,7 +599,8 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev)
? ? ? ?/* Register interrupt ?- SwAdcComplete */
? ? ? ?ret = request_threaded_irq(gpadc->irq, NULL,
? ? ? ? ? ? ? ?ab8500_bm_gpswadcconvend_handler,
- ? ? ? ? ? ? ? IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc", gpadc);
+ ? ? ? ? ? ? ? IRQF_ONESHOT | IRQF_NO_SUSPEND | IRQF_SHARED,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? "ab8500-gpadc", gpadc);
Looks correct to me I think this one should be ONESHOT anyway.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help