[PATCH v2 2/2] regulator: Add support for MAX77686.

Hi Mark,

On Sun, May 20, 2012 at 3:30 PM, Mark Brown
[off-list ref] wrote:

On Thu, May 17, 2012 at 07:09:27PM +0530, Yadwinder Singh Brar wrote:

Looks mostly good. ?A couple of fairly small things:

quoted

+static int max77686_get_voltage_sel(struct regulator_dev *rdev)
+{

This looks like it should be regulator_get_voltage_sel_regmap().

quoted

+static int max77686_set_voltage_sel(struct regulator_dev *rdev,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? unsigned sel)
+{

This looks like it should be regulator_set_voltage_sel_regmap().

Yes, We can use  regulator_set_voltage_sel_regmap(), I will replace it.

quoted

+ ? ? max77686->ramp_delay = pdata->ramp_delay - 1;
+ ? ? max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1,
+ ? ? ? ? ? ? RAMP_VALUE, RAMP_MASK);
+ ? ? max77686_update_reg(i2c, MAX77686_REG_BUCK3CTRL1,
+ ? ? ? ? ? ? RAMP_VALUE, RAMP_MASK);
+ ? ? max77686_update_reg(i2c, MAX77686_REG_BUCK4CTRL1,
+ ? ? ? ? ? ? RAMP_VALUE, RAMP_MASK);

This code is unclear because RAMP_VALUE looks like a constant that has
nothing to do with ramp_delay when in fact it's actually this:

quoted

+#define RAMP_VALUE (max77686->ramp_delay << 6)

which isn't constant - this is why I queried this last time. ?Just
remove the define and write this out directly. ?The way the code is
written at the minute it looks like ramp_delay is just stored and not
referred to unless you go searching around the rest of the driver.

Ok, I will remove it.

Thanks,
Yadwinder.