On Thursday 15 March 2012, Russell King - ARM Linux wrote:

On Thu, Mar 15, 2012 at 05:36:04PM +0000, Lee Jones wrote:

quoted

On 15/03/12 17:32, Russell King - ARM Linux wrote:

quoted

On Wed, Mar 14, 2012 at 02:20:00PM +0000, Lee Jones wrote:

quoted

This is a step in the right direction for future Device
Tree support. It will allow variant specific attributes
to be collected from a Device Tree without overloading
the MMCI core. It will also provide additional future
variants a cleaner way to add support.

NAK.  You can't have two driver structures with the same name.  The names
are sysfs object names.

Well spotted.

I've already changed this in v2. :)

I'm not in favour of splitting the two variants either btw.

Can you elaborate? I suggested the split in order to keep the ux500
specific parts local to one file. With the device tree conversion,
we really want to have them out of the platform code, but sticking them
into the main driver seems wrong, too.

I don't mind leaving the ARM and u300 specific bits in the main driver,
but I think having the ux500 parts separate does indeed help.

	Arnd