Thread (2 messages) flat view 2 messages, 2 authors, 2012-03-06
STALE5288d

[PATCH] ARM: OMAP2+: voltage: ensure voltage used is exact voltage from OPP table

From: Kevin Hilman <hidden>
Date: 2012-03-05 18:12:15
Also in: linux-omap

Tero Kristo [off-list ref] writes:
On Fri, 2012-03-02 at 14:42 -0800, Kevin Hilman wrote:
quoted
When using the SMPS regulators to scale voltages, the regulator
framework may pass a minimum voltage that is not an exact OPP voltage.
For the VC/VP controlled voltage domains, we must ensure that the
voltage requested is the exact voltage from the OPP table.  This is
especially critical when using SR.

To fix, voltdm_scale() uses the target voltage passed to walk through
the OPP voltages until it finds a voltage that is >= one of the OPP
voltages.
I have just one question to this, how about smartreflex class1p5? Do we
have any plans for that one? The old implementation at least was using
voltdm_scale, so if we modify this function, smartreflex class1p5
doesn't work anymore.
Since it's not in mainline, that is not my concern at the moment.  We
can worry about SR1.5 when I someone is motivated to push it upstream.
Otherwise this patch looks good to me.
Thanks for looking.

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help