On Fri, Mar 30, 2012 at 7:37 AM, Stephen Boyd [off-list ref] wrote:

On 02/27/12 04:15, MyungJoo Ham wrote

quoted

+static irqreturn_t gpio_irq_handler(int irq, void *dev_id)
+{
+ ? ? struct gpio_extcon_data *extcon_data =
+ ? ? ? ? (struct gpio_extcon_data *)dev_id;

Casting from void is unnecessary.

quoted

+
+static int gpio_extcon_probe(struct platform_device *pdev)

__devinit?

quoted

+{
+ ? ? struct gpio_extcon_platform_data *pdata = pdev->dev.platform_data;
+ ? ? struct gpio_extcon_data *extcon_data;
+ ? ? int ret = 0;

[snip]

quoted

+ ? ? return ret;
+}
+
+static int gpio_extcon_remove(struct platform_device *pdev)

__devexit?

quoted

+{
+ ? ? struct gpio_extcon_data *extcon_data = platform_get_drvdata(pdev);

[snip]

quoted

+static struct platform_driver gpio_extcon = {
+ ? ? .probe ? ? ? ? ?= gpio_extcon_probe,
+ ? ? .remove ? ? ? ? = gpio_extcon_remove,

__devexit_p()?

quoted

+ ? ? .driver ? ? ? ? = {
+ ? ? ? ? ? ? .name ? = "extcon-gpio",
+ ? ? ? ? ? ? .owner ?= THIS_MODULE,
+ ? ? },
+};
+
+module_platform_driver(gpio_extcon);
+
+MODULE_AUTHOR("Mike Lockwood [off-list ref]");
+MODULE_DESCRIPTION("GPIO extcon driver");
+MODULE_LICENSE("GPL");

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Thank you for the comments.

I'll apply it and test on patchset v8.



Cheers!
MyungJoo.

-- 
MyungJoo Ham, Ph.D.
Mobile Software Platform Lab, DMC Business, Samsung Electronics