[PATCH v6 1/5] Extcon (external connector): import Android's switch class and modify.

On Fri, Mar 9, 2012 at 4:41 AM, Mark Brown
[off-list ref] wrote:

On Mon, Feb 27, 2012 at 09:15:35PM +0900, MyungJoo Ham wrote:

quoted

+#ifdef CONFIG_ANDROID
+ ? ? ? ? ? ? extcon_class = class_create(THIS_MODULE, "switch");
+#else /* !CONFIG_ANDROID */
+ ? ? ? ? ? ? extcon_class = class_create(THIS_MODULE, "extcon");
+#endif /* CONFIG_ANDROID */

This seems somewhat sad - if ANDROID is turned on the standard ABI
vanishes. ?It'd be much nicer to do this with a symlink (or with
symlinks within the android directory if the driver core doesn't support
that). ?That way userspace code can be written to the new ABI and will
work on Android systems without ifdefery.

This won't work if userspace code is receiving uevents through netlink
and comparing based on the device name which it does in android.  Why
change the name at all?  Extcon is much more specific than "switch."
A switch can can be used for more than just external connections such
as availability of HMDI audio (which is only available once a HDMI
mode is chosen and the interface is enabled.)

-Erik