Thread (27 messages) flat view 27 messages, 5 authors, 2012-03-09

[PATCH 2/4] mmc: omap_hsmmc: Use gpio_find_by_chip_name() for omap_hsmmc_gpio_init()

From: tony@atomide.com (Tony Lindgren)
Date: 2012-03-02 18:35:11
Also in: linux-mmc, linux-omap, lkml

* Tony Lindgren [off-list ref] [120302 08:38]:
* Rajendra Nayak [off-list ref] [120301 22:54]:
quoted
quoted
@@ -2093,8 +2123,7 @@ err1:
 	platform_set_drvdata(pdev, NULL);
 	mmc_free_host(mmc);
 err_alloc:
-	omap_hsmmc_gpio_free(pdata);
-err:
+	omap_hsmmc_gpio_free(host);
This error handling needs to be fixed up. In case
omap_hsmmc_gpio_init() fails, which already frees up
any requested gpios, omap_hsmmc_gpio_free() again tries
freeing gpios.
Hmm that sounds like a separate patch that should be a fixed
before this series?
Nope, I was confused. The error handling needs to change
as the omap_hsmmc_gpio_init() got moved later so host is
initialized. Will fix.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help