Kyungmin Park wrote:

On 2/1/12, Russell King - ARM Linux [off-list ref] wrote:

quoted

On Wed, Feb 01, 2012 at 12:50:39AM +0900, Kukjin Kim wrote:

quoted

From: Sangsu Park <redacted>

This patch adds follwing.
- IO-map for EXYNOS5250 GPIO support
- EXYNOS5250 GPIO bank size/number definitions
- memory map definition for S5P GPIO4

Signed-off-by: Sangsu Park <redacted>
Signed-off-by: Kukjin Kim <redacted>

Do you actually need these static mapping definitions?  The samsung
gpiolib initialization is called from a core_initcall(), and at this
time ioremap() is fully capable of working.

If it assumes it has 8 gpios, you can make it simple calculate it like
this.

But unfortunately, it has not 8 gpios in each gpio bank.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

enum exynos5_gpios {
     EXYNOS5_GPIO_A,
     ...
};

EXYNOS5_GPIO_A_START(n)          (EXYNOS5_GPIO_A * 8)

with this one, it can make a simple gpio driver when using irq domain for
GPIO.