On Tue, Jan 31, 2012 at 10:40:43PM +0000, Russell King - ARM Linux wrote:

On Wed, Feb 01, 2012 at 12:50:39AM +0900, Kukjin Kim wrote:

quoted

From: Sangsu Park <redacted>

This patch adds follwing.
- IO-map for EXYNOS5250 GPIO support
- EXYNOS5250 GPIO bank size/number definitions
- memory map definition for S5P GPIO4

Signed-off-by: Sangsu Park <redacted>
Signed-off-by: Kukjin Kim <redacted>

Do you actually need these static mapping definitions?  The samsung
gpiolib initialization is called from a core_initcall(), and at this
time ioremap() is fully capable of working.

Indeed.  Please get rid of the S5P_VA_GPIO* macros and use ioremap to
set up the registers mappings.  I understand that the existing code
already does that, but I don't want to see any more added.  Also, it
is easy to fix by adding the ioremap calls to samsung_gpio_init()

g.