Kyungmin Park wrote:

On 2/1/12, Kukjin Kim [off-list ref] wrote:

[snip]

quoted

+static int exynos5_clk_gate_block(struct clk *clk, int enable)

exynos5_clk_block_ctrl?

OK, looks better, will change.

[snip]

quoted

+		.name		= "mfc",
+		.devname	= "s3c-mfc",

what's this?

typo :( should be s5p-mfc.

[snip]

quoted

+		.name		= "hdmi",
+		.devname	= "exynos5-hdmi",

I think exynos4x12 has same hdmi controller. so It will be changed as
exynos-hdmi.

OK, let me check it but I'm not sure new exynos will have same hdmi later.

[snip]

quoted

+		.name		= "fimg2d",
+		.devname	= "s5p-fimg2d",

s5p? exynos?

Hmm, let me think again.

[snip]

Thanks :)

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.