[PATCH] arm: omap3: cm-t35: fix section mismatch warning
From: tony@atomide.com (Tony Lindgren)
Date: 2012-02-08 05:35:57
Also in:
linux-omap
* Igor Grinberg [off-list ref] [120205 03:08]:
WARNING: arch/arm/mach-omap2/built-in.o(.text+0xeae8): Section mismatch in reference from the function cm_t35_init_usbh() to the (unknown reference) .init.data:(unknown) The function cm_t35_init_usbh() references the (unknown reference) __initdata (unknown). This is often because cm_t35_init_usbh lacks a __initdata annotation or the annotation of (unknown) is wrong. Signed-off-by: Igor Grinberg <redacted> --- Sorry about this one. I fixed similar problem for cm-t3517 a while ago, but somehow missed cm-t35. Thanks for spotting. Probably enabling the CONFIG_DEBUG_SECTION_MISMATCH in defconfigs can raise people awareness for this.
Thanks applying into fixes. Yes let's plan on doing that, and also make sure we're actually seeing the warnings.. Tony
quoted hunk ↗ jump to hunk
arch/arm/mach-omap2/board-cm-t35.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c index d839c05..a8cedbe 100644 --- a/arch/arm/mach-omap2/board-cm-t35.c +++ b/arch/arm/mach-omap2/board-cm-t35.c@@ -436,7 +436,7 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = { .reset_gpio_port[2] = -EINVAL }; -static void cm_t35_init_usbh(void) +static void __init cm_t35_init_usbh(void) { int err;-- 1.7.3.4