[PATCH 2/3] ARM: make disable_fiq macro optional

On 02/06/2012 11:24 PM, Nicolas Pitre wrote:

On Mon, 6 Feb 2012, Rob Herring wrote:

quoted

Nicolas,

On 02/06/2012 04:34 PM, Nicolas Pitre wrote:

quoted

On Mon, 6 Feb 2012, Rob Herring wrote:

quoted

From: Rob Herring <redacted>

Only rpc uses disable_fiq, so make its use conditional on ARCH_RPC.

With this, entry-macro.S is no longer needed for platforms that
select MULTI_IRQ_HANDLER and the include of it can be conditional.

Using set_fiq_handler() in the rpc boot code we could get rid of 
disable_fiq entirely.

That's already being done here:
arch/arm/mach-rpc/dma.c:290:    set_fiq_handler(fiqhandler_start,
fiqhandler_length);

Can the macro just be deleted? Or a default handler needs to be setup
earlier?

That's the handler installed by the RPC DMA code.  Another one is needed 
by default for when that code is not active.

Wouldn't the fiq be masked then? rpc_init_irq masks out the interrupts
in the same register as disable_fiq macro:

iomd_writeb(0, IOMD_FIQMASK);

Rob