Thread (20 messages) flat view 20 messages, 8 authors, 2012-02-08
STALE5295d

Revision v1 of 5 in this series.

Revisions (5)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 current
  5. v2 [diff vs current]

[PATCH 2/3] ARM: make disable_fiq macro optional

From: nico@fluxnic.net (Nicolas Pitre)
Date: 2012-02-07 05:24:15

On Mon, 6 Feb 2012, Rob Herring wrote:
Nicolas,

On 02/06/2012 04:34 PM, Nicolas Pitre wrote:
quoted
On Mon, 6 Feb 2012, Rob Herring wrote:
quoted
From: Rob Herring <redacted>

Only rpc uses disable_fiq, so make its use conditional on ARCH_RPC.

With this, entry-macro.S is no longer needed for platforms that
select MULTI_IRQ_HANDLER and the include of it can be conditional.
Using set_fiq_handler() in the rpc boot code we could get rid of 
disable_fiq entirely.
That's already being done here:
arch/arm/mach-rpc/dma.c:290:    set_fiq_handler(fiqhandler_start,
fiqhandler_length);

Can the macro just be deleted? Or a default handler needs to be setup
earlier?
That's the handler installed by the RPC DMA code.  Another one is needed 
by default for when that code is not active.


Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help