[PATCH 6/6] ARM: imx6q-sabrelite: add audmux support

On Mon, Jan 09, 2012 at 09:19:50AM +0800, Shawn Guo wrote:

On Sun, Jan 08, 2012 at 10:58:14PM +0800, Richard Zhao wrote:

quoted

On Sun, Jan 08, 2012 at 11:02:36PM +0800, Shawn Guo wrote:

quoted

On Fri, Jan 06, 2012 at 11:25:43AM +0800, Richard Zhao wrote:

quoted

--- a/arch/arm/boot/dts/imx6q.dtsi
+++ b/arch/arm/boot/dts/imx6q.dtsi

@@ -527,7 +527,9 @@
 			};
 
 			audmux at 021d8000 {
+				compatible = "fsl,audmux-v2";

This is not a good compatible string, because the version number is
not defined by hardware.  Even it is defined by hardware, the version
number is not as stable as soc to identify specific hardware block.
You can look at uart, cspi, sdma etc. for examples.

compatible = "fsl,imx6q-audmux", "fsl,imx25-audmux";
I forgot imx25 or imx31 is oldest. Is it ok for you?

Yes.

Forgot mentioning that imx31 was born earlier than imx25, so I would
expect it be: 

	compatible = "fsl,imx6q-audmux", "fsl,imx31-audmux";

-- 
Regards,
Shawn