Thread (40 messages) flat view 40 messages, 9 authors, 2012-01-12
STALE5355d

Revision v1 of 5 in this series.

Revisions (5)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 current
  5. v2 [diff vs current]

[PATCH 6/6] ARM: imx6q-sabrelite: add audmux support

From: Shawn Guo <hidden>
Date: 2012-01-09 01:19:50

On Sun, Jan 08, 2012 at 10:58:14PM +0800, Richard Zhao wrote:
On Sun, Jan 08, 2012 at 11:02:36PM +0800, Shawn Guo wrote:
quoted
On Fri, Jan 06, 2012 at 11:25:43AM +0800, Richard Zhao wrote:
quoted
--- a/arch/arm/boot/dts/imx6q.dtsi
+++ b/arch/arm/boot/dts/imx6q.dtsi
@@ -527,7 +527,9 @@
 			};
 
 			audmux at 021d8000 {
+				compatible = "fsl,audmux-v2";
This is not a good compatible string, because the version number is
not defined by hardware.  Even it is defined by hardware, the version
number is not as stable as soc to identify specific hardware block.
You can look at uart, cspi, sdma etc. for examples.
compatible = "fsl,imx6q-audmux", "fsl,imx25-audmux";
I forgot imx25 or imx31 is oldest. Is it ok for you?
Yes.

-- 
Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help