Hi Mark
On 1 January 2012 05:59, Mark Brown [off-list ref] wrote:

On Sat, Dec 31, 2011 at 09:26:30AM +0800, Richard Zhao wrote:

quoted

On Sat, Dec 31, 2011 at 01:02:40AM +0000, Mark Brown wrote:

quoted

quoted

quoted

quoted

It shouldn't actually be passing on the constraint setting the voltage
when it constructs the constraints.

quoted

The below code is where fixed regulator construct the constraints.

It's not code which is specific to the fixed regulator, it's generic
code that's used by all regulators.

The original patch is in fixed regulator driver.

quoted

quoted

quoted

- ? ? ? /* Only one voltage? ?Then make sure it's set. */
- ? ? ? if (constraints->min_uV == constraints->max_uV)
- ? ? ? ? ? ? ? constraints->apply_uV = true;

quoted

quoted

No! ?That's going to break *all* other users.

quoted

The above code follows your idea. why you still say no?

You're just randomly inserting code for a specific driver into the
generic regulator API with no consideration for the effect on other
users.

quoted

Could you please past some code to show your suggested solution,
or you send out a patch to fix it?

Not in the immediate future.

It's a __bug__ blocking others to use fixed regulator with dt binding.

Thanks
Richard