On 21 December 2011 22:14, Janusz Krzysztofik [off-list ref] wrote:
On Wednesday 21 of December 2011 at 19:33:44, Liam Girdwood wrote:
quoted
On Sun, 2011-12-11 at 21:12 +0100, Janusz Krzysztofik wrote:
quoted
Don't use Amstrad Delta custom I/O functions any longer, replace them
with GPIO. Old pin definitions, no longer used by the modem bits either,
can be dropped.
Depends on patch 2/10 "ARM: OMAP1: Convert Amstrad E3 latches to
basic_mmio_gpio".
Signed-off-by: Janusz Krzysztofik <redacted>
Applied.
Hi,
I'm sorry, but I've probably missed to infrom you explicitly, i.e. other
than in a cover letter to v2 of this series, that this particular patch
has been dropped from the series. I've already started working on an
alternative solution, which I intend to submit as a separate set. It
will be free of potentail problems with two devices, a modem and the
sound card, accessing the same GPIO pins concurrently. For the
MODEM_NRESET pin I've already set up a virtual regulator on top of it,
and for the MODEM_CODEC pin I'll probably choose a virtual clock (pinmux
would match the hardware more closely here, but it looks too complicated
to me). Moreover, I've already started to move all those GPIO pin
related functions, i.e. bias control, digital mute and line discipline
interaction, from the board file to the codec driver, where all those
seem to belong.
Having this patch applied will conflict with the regultor and the clock
solutions, taking control over those two GPIO pins. Please revert this
patch, or reset it if still possible.
Thanks,
Janusz
Will do, I never pushed last night as it was late. So I'll only will
have to make a local change.
Thanks
Liam