* Janusz Krzysztofik [off-list ref] [111201 10:48]:
On Thursday 01 of December 2011 at 20:04:55, Tony Lindgren wrote:
quoted
From: Tony Lindgren <tony@atomide.com>
Date: Thu, 1 Dec 2011 11:00:11 -0800
Subject: [PATCH] ARM: OMAP1: Fix reprogramming of DPLL1 for systems that boot at rates below 60MHz
Commit e9b7086b80c4d9e354f4edc9e280ae85a60df408 (ARM: OMAP: Fix
reprogramming of dpll1 rate) fixed a regression for systems that
did not rely on bootloader set rates.
However, it also introduced a new problem where the rates selected
in .config would not take affect as omap1_select_table_rate
currently refuses to reprogram DPLL1 if it's already initialized.
This was not a problem earlier, as the reprogramming was done
earlier with ck_dpll1_p->rate uninitialized.
Fix this by forcing the reprogramming on systems booting at rates
below 60MHz. Note that the long term fix is to make the rates
SoC specific later on.
Thanks for Janusz Krzysztofik [off-list ref] for figuring
this one out.
Reported-by: Janusz Krzysztofik <redacted>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Janusz Krzysztofik <redacted>
However, this way or another, we are back to your mentioned problem of
omap1_defconfig always switching to 216 MHz, I'm afraid. Then, 2a/5 v1
"Remove unsafe clock values from omap1_defconfig" can still be helpful.
OK that makes sense now also in case there are other systems that
boot at rates below 60MHz.
Anyway, I'm resending (refreshed) 2/5 and 5/5 as rc fixes as you
suggested before, 1/5 "ARM: OMAP1: Fix dpll1 default rate reprogramming
method" intended for next, and 2a/5 v2 "ARM: OMAP1: select clock rate by
CPU type" also for next but as an RFC.
Great, sounds like we got the fixes needed for the -rc cycle then.
Regards,
Tony