Thread (7 messages) read the whole thread 7 messages, 3 authors, 2011-11-02

[PATCH] i2c-gpio.c: correct logic of pdata->scl_is_open_drain

From: Voss, Nikolaus <hidden>
Date: 2011-11-01 08:02:22
Also in: lkml

It is never correct to use push-pull I/O for i2c, so the flag does not
specify the desired behavior of the driver, it specifies what the
hardware has been configured to do so that the driver can choose the
cheapest way to do open-drain I/O.
Ok, seems rather logical after all.
And even if you could argue that the flag should be inverted, it has
had the same meaning since the driver was introduced several years
ago, so changing it now will break every single platform which
currently uses i2c-gpio.
I completely agree.

Thanks for the explanation,
Niko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help