Thread (7 messages) 7 messages, 3 authors, 2011-11-02

[PATCH] i2c-gpio.c: correct logic of pdata->scl_is_open_drain

From: Håvard Skinnemoen <hidden>
Date: 2011-10-31 21:21:58
Also in: lkml

On Mon, Oct 31, 2011 at 9:14 AM, Voss, Nikolaus [off-list ref] wrote:
If pdata->scl_is_open_drain was set, the driver used push-pull output
for SCL, not open-drain output.

Signed-off-by: Nikolaus Voss <redacted>
{sda,scl}_is_open_drain indicates that the GPIO hardware is set up to
do open drain so the software doesn't have to, i.e.
gpio_set_value(pin, 1) will turn off the output driver rather than
drive the pin high, so the _val functions will do the right thing.

In other words, the existing code is correct.

Havard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help