On Thu, Sep 1, 2011 at 11:26 AM, Kukjin Kim [off-list ref] wrote:

Tomasz Figa wrote:

quoted

2011/8/31 Mark Brown [off-list ref]:

quoted

On Wed, Aug 31, 2011 at 02:34:15PM +0200, Tomasz Figa wrote:

quoted

This patch is a prerequisite to adding generic time support for

S3C64xx.

quoted

quoted

quoted

It makes possible to differentiate SoCs, required to exclude timers 3

and 4

quoted

quoted

quoted

from PWM driver only on S3C64xx.

Now we have the cpu_is_foo() support for Samsung CPUs can we use that
instead?

Well, I thought about it, but I based my patches on latest stable sources

and

quoted

cpu_is_s3c64xx wasn't there yet. Should I rebase them to Linus' tree?

I'm not yet fully used to submitting patches here, so things like choosing

the

quoted

base for patches are sometimes a bit confusing to me and I couldn't find

any

quoted

guide. Should fixes be based on stable tree and new features implemented

on

quoted

top of current Linus' tree? Could you give me some advice on this?

Hi Tomasz,

You can use "soc_is_s3c64xx()" based on Samsung -next tree.
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
for-next

+static struct platform_device_id s3c_pwm_driver_ids[] = {
+       {
+               .name           = "s3c24xx-pwm",
+               .driver_data    = TYPE_GENERIC,
+       }, {
+               .name           = "s3c64xx-pwm",
+               .driver_data    = TYPE_S3C64XX,
+       },
+};
+MODULE_DEVICE_TABLE(platform, s3c_pwm_driver_ids);

doesn't it right way?
do you want to use the soc_is_* at device?

In addition, would be better to me if you could work about Samsung stuff
based on it.

As a note, your previous patches are in there :)

If any problems, please let me know...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel