Thread (21 messages) 21 messages, 5 authors, 2011-10-13
STALE5380d

[PATCH 1/5] ARM: Samsung: PWM: Allow to differentiate SoCs based on platform device name.

From: Tomasz Figa <hidden>
Date: 2011-09-01 11:18:32

On Thursday 01 of September 2011 at 12:33:10, Kyungmin Park wrote:
On Thu, Sep 1, 2011 at 11:26 AM, Kukjin Kim [off-list ref] wrote:
quoted
Tomasz Figa wrote:
quoted
2011/8/31 Mark Brown [off-list ref]:
quoted
On Wed, Aug 31, 2011 at 02:34:15PM +0200, Tomasz Figa wrote:
quoted
This patch is a prerequisite to adding generic time support for
S3C64xx.
quoted
quoted
quoted
It makes possible to differentiate SoCs, required to exclude timers 3
and 4
quoted
quoted
quoted
from PWM driver only on S3C64xx.
Now we have the cpu_is_foo() support for Samsung CPUs can we use that
instead?
[snip]
Hi Tomasz,

You can use "soc_is_s3c64xx()" based on Samsung -next tree.
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
for-next
+static struct platform_device_id s3c_pwm_driver_ids[] = {
+       {
+               .name           = "s3c24xx-pwm",
+               .driver_data    = TYPE_GENERIC,
+       }, {
+               .name           = "s3c64xx-pwm",
+               .driver_data    = TYPE_S3C64XX,
+       },
+};
+MODULE_DEVICE_TABLE(platform, s3c_pwm_driver_ids);

doesn't it right way?
do you want to use the soc_is_* at device?
Well, now we have three alternatives:
- to leave it as is (i.e. changing platform device names)
- to use cpu_is_* (does it ever exist for S3C64xx or soc_is_s3c64xx is its equivalent?)
- to use soc_is_* 

Waiting for more comments then.

Best regards,
Tom
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help