Thread (81 messages) 81 messages, 11 authors, 2011-09-20
STALE5422d

[PATCH 14/25] OMAP4: PM: Add CPUX OFF mode support

From: Shawn Guo <hidden>
Date: 2011-09-10 04:54:55
Also in: linux-omap

On Sat, Sep 10, 2011 at 09:08:16AM +0530, Shilimkar, Santosh wrote:
IOn Sat, Sep 10, 2011 at 5:04 AM, Shawn Guo [off-list ref] wrote:
[...]
quoted
Also, IMO, lable "l2x_clean_inv" should be put after the "bne do_WFI".
Otherwise, my original statement (it seems l2x_clean_inv will be
called for case "2") stands correct :)
It's just a label. All L2 related code and checks for the valid state is
kept under that by purpose.
So for some case, you enter l2x_clean_inv but do not actually clean
and invalidate L2.  I do not see this label being used anywhere, so
you may want to remove it to save the confusion to stupid people like
me.  Just my opinion.

-- 
Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help