On Tuesday 27 September 2011 05:46 PM, Mark Brown wrote:

On Tue, Sep 27, 2011 at 03:42:48PM +0530, Rajendra Nayak wrote:

quoted

The helper routine of_get_fixed_voltage_config() extracts
fixed_voltage_config structure contents from device tree.

Also add documenation for additional bindings for fixed
regulators that can be passed through dt.

Why not just add device tree support into the driver directly?

Ok, will do.

quoted

+Optional properties:
+- regulator-fixed-supply: Name of the regulator supply

This is going to be confusing with respect to the generic regulator
supply property.

Yes, I guess. Any suggestions on how to make it less
confusing? :-)

quoted

+- regulator-fixed-enable-high: Polarity of enable GPIO, 1 = Active High, 0 = Active low

Word wrap for legibility please.

Ok.