On Friday 16 September 2011 02:27 PM, Mark Brown wrote:

On Fri, Sep 16, 2011 at 12:41:53PM +0530, Rajendra Nayak wrote:

quoted

On Thursday 15 September 2011 07:02 PM, Mark Brown wrote:

quoted

On Thu, Sep 15, 2011 at 04:51:57PM +0530, Rajendra Nayak wrote:

quoted

quoted

quoted

There is no need for all the board files to pass this information
additionally, when the driver already sets them by default.

quoted

quoted

"the driver"?  This sounds very buggy...

quoted

Yeah, the driver currently sets some default based on what
the chip itself supports and completely ignores the board
inputs.
How about the driver using the defaults and letting the boards
override it (if it ever wants to)?
Currently none of the boards (using any of the twl
regulators) seem to override the defaults and that way a lot of
this duplication in board files could be avoided.

No, this is just plain buggy.  It's fine for OMAP to have some common
stuff that the board reference but if the drivers are doing this that's
bad.  The drivers and framework shouldn't touch the hardware unless the
board says it's OK.

fair enough, I'll fix up the driver then.