On Fri, Sep 16, 2011 at 12:47:05PM +0530, Rajendra Nayak wrote:

On Thursday 15 September 2011 07:16 PM, Mark Brown wrote:

quoted

On Thu, Sep 15, 2011 at 04:52:00PM +0530, Rajendra Nayak wrote:

quoted

quoted

+Required properties:
+- compatible: Must be "regulator","ti,twl-reg";

quoted

I'd expect listings for the specific chips too.

I just did'nt do that because we have just one driver for
all twl chips (twl4030/twl6030/twl6025) and there seems to be
no real need to identify specific chips while we could
do knowing just the chip family.

The driver can bind to as many names as it likes.

quoted

quoted

+	xyz-regulator: regulator at 0 {
+		compatible = "regulator","ti,twl-reg";
+		ti,reg-id =<37>; /* TWL6030_REG_VAUX1_6030 */

quoted

These magic numbers are *very* Linux specific, we should have a better
way of specifying regulators - I'd off the top of my head expect that
the compatible property would identify the regulator.

The driver seems to use a per-regulator table, and it uses the above
id to indexed into it. I could probably do it with the compatible

I know what the driver is doing, the problem is that it's very much
specific to Linux (and Linux may change the numbers at some point).

property, but that would mean I have a compatible for *each* regulator
instance, like "ti,twl-reg-vaux1", "ti,twl-reg-vmmc" etc.
Does that sound reasonable?

Yes.