[PATCH 4/5] ARM: gic: allow irq_start to be 0
flat view
From: Grant Likely <hidden>
Date: 2011-09-18 06:32:26
Also in:
linux-devicetree, lkml
On Wed, Sep 14, 2011 at 11:31:39AM -0500, Rob Herring wrote:
From: Rob Herring <redacted> There's really no need to set irq_start per platform for the primary gic. The SGIs and PPIs are not handled as normal irqs, so how irqs 0-31 are setup doesn't really matter. So allow irq_start to be set to 0 to match the linux irq numbering.
Is this really what you want? Linux irq 0 is not supposed to be used. With the transition to dynamically allocated irq_descs, I want to make sure 0 never gets assigned. g.
quoted hunk ↗ jump to hunk
Signed-off-by: Rob Herring <redacted> --- arch/arm/common/gic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c index 666b278..d1ccc72 100644 --- a/arch/arm/common/gic.c +++ b/arch/arm/common/gic.c@@ -359,7 +359,7 @@ void __init gic_init(unsigned int gic_nr, unsigned int irq_start, gic = &gic_data[gic_nr]; gic->dist_base = dist_base; gic->cpu_base = cpu_base; - gic->irq_offset = (irq_start - 1) & ~31; + gic->irq_offset = irq_start ? (irq_start - 1) & ~31 : 0; if (gic_nr == 0) gic_cpu_base_addr = cpu_base;-- 1.7.5.4