Thread (56 messages) 56 messages, 11 authors, 2011-09-20

[PATCH 3/5] of/irq: introduce of_irq_init

flat view

From: arnd@arndb.de (Arnd Bergmann)
Date: 2011-09-15 10:41:46
Also in: linux-devicetree, lkml

On Wednesday 14 September 2011, Rob Herring wrote:
From: Rob Herring <redacted>

of_irq_init will scan the devicetree for matching interrupt controller
nodes. Then it calls an initialization function for each found controller
in the proper order with parent nodes initialized before child nodes.

Based on initial pseudo code from Grant Likely.

Signed-off-by: Rob Herring <redacted>
Cc: Grant Likely <redacted>
Looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>
quoted hunk ↗ jump to hunk
+
+struct intc_desc {
+       struct list_head        list;
+       struct device_node      *dev;
+       struct device_node      *parent;
+};
One tiny comment: how about naming the parent 'interrupt_parent'? While
reading through the code, I was confused for a short time until I figured
out what this is about.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help