[PATCH v5 15/22] gpio/omap: use readl in irq_handler for all access
From: Santosh <hidden>
Date: 2011-08-23 14:25:44
Also in:
linux-omap
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote:
From: Charulatha V<redacted> Even when bank->width is 16, all the OMAP1 registers are 4-byte aligned, so just use a 4-byte read. The 'enabled' mask is already taking care to mask for bank width. Signed-off-by: Charulatha V<redacted> Signed-off-by: Tarun Kanti DebBarma<redacted> ---
Patch $SUBJECT and the change don't match. May be you want to say remove un-necessary bit masking since the register are 4 byte aligned and readl would work as is.
quoted hunk ↗ jump to hunk
drivers/gpio/gpio-omap.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 3d18cdf..ba20e42 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c@@ -572,8 +572,6 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) enabled = _get_gpio_irqbank_mask(bank); isr_saved = isr = __raw_readl(isr_reg)& enabled; - if (cpu_is_omap15xx()&& (bank->method == METHOD_MPUIO)) - isr&= 0x0000ffff; if (bank->level_mask) level_mask = bank->level_mask& enabled;