Thread (8 messages) flat view 8 messages, 4 authors, 2011-08-19
STALE5507d

[PATCH] ARM: S3C64XX: Remove un-used code

From: Kukjin Kim <hidden>
Date: 2011-08-19 05:29:44
Also in: linux-samsung-soc

Mark Brown wrote:
On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote:
quoted
On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
[off-list ref] wrote:
quoted
On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote:
quoted
Remove un-used backlight code for SMDK6410 board
quoted
quoted
Is the data actually wrong? ?If not it'd seem better to finish hooking
it up properly than to remove it.
quoted
No, this code is no longer needed, as we are having a common backlight
infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're
just deleting unreferenced code.
Yes, I agree with your opinion...It was difficult to know why it is un-used
code when I applied that.

OK, I will amend its commit log in my tree to clear.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help