[PATCH] ARM: S3C64XX: Remove un-used code
Subsystems:
arm port , the rest
5500d
8 messages,
4 authors,
2011-08-19 · open the first message on its own page
Remove un-used backlight code for SMDK6410 board
Signed-off-by: Banajit Goswami <redacted>
---
arch/arm/mach-s3c64xx/mach-smdk6410.c | 39 ---------------------------------
1 files changed, 0 insertions(+), 39 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-s3c64xx/mach-smdk6410.c
index ecbea92..a9f3183 100644
--- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
+++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c @@ -262,45 +262,6 @@ static struct samsung_keypad_platdata smdk6410_keypad_data __initdata = {
. cols = 8 ,
};
- static int smdk6410_backlight_init ( struct device * dev ) - { - int ret ; - - ret = gpio_request ( S3C64XX_GPF ( 15 ), "Backlight" ); - if ( ret ) { - printk ( KERN_ERR "failed to request GPF for PWM-OUT1 \n " ); - return ret ; - } - - /* Configure GPIO pin with S3C64XX_GPF15_PWM_TOUT1 */ - s3c_gpio_cfgpin ( S3C64XX_GPF ( 15 ), S3C_GPIO_SFN ( 2 )); - - return 0 ; - } - - static void smdk6410_backlight_exit ( struct device * dev ) - { - s3c_gpio_cfgpin ( S3C64XX_GPF ( 15 ), S3C_GPIO_OUTPUT ); - gpio_free ( S3C64XX_GPF ( 15 )); - } - - static struct platform_pwm_backlight_data smdk6410_backlight_data = { - . pwm_id = 1 , - . max_brightness = 255 , - . dft_brightness = 255 , - . pwm_period_ns = 78770 , - . init = smdk6410_backlight_init , - . exit = smdk6410_backlight_exit , - }; - - static struct platform_device smdk6410_backlight_device = { - . name = "pwm-backlight" , - . dev = { - . parent = & s3c_device_timer [ 1 ]. dev , - . platform_data = & smdk6410_backlight_data , - }, - }; - static struct map_desc smdk6410_iodesc [] = {};
static struct platform_device * smdk6410_devices [] __initdata = { --
1.7.2.3
On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: Remove un-used backlight code for SMDK6410 board
Is the data actually wrong? If not it'd seem better to finish hooking
it up properly than to remove it.
Hi Mark,
On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
[off-list ref] wrote: On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: quoted Remove un-used backlight code for SMDK6410 board
Is the data actually wrong? ?If not it'd seem better to finish hooking
it up properly than to remove it. No, this code is no longer needed, as we are having a common backlight
infrastructure , which serves the same purpose.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html
Thanks and Regards,
Banajit Goswami
On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote: On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
[off-list ref] wrote: quoted On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: quoted Remove un-used backlight code for SMDK6410 board quoted Is the data actually wrong? ?If not it'd seem better to finish hooking
it up properly than to remove it. No, this code is no longer needed, as we are having a common backlight
infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're
just deleting unreferenced code.
Banajit Goswami wrote:
Remove un-used backlight code for SMDK6410 board
Signed-off-by: Banajit Goswami <redacted>
---
arch/arm/mach-s3c64xx/mach-smdk6410.c | 39 --------------------------------- quoted hunk 1 files changed, 0 insertions(+), 39 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach- s3c64xx/mach-smdk6410.c
index ecbea92..a9f3183 100644 --- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
+++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c @@ -262,45 +262,6 @@ static struct samsung_keypad_platdata smdk6410_keypad_data __initdata = {
.cols = 8,
};
-static int smdk6410_backlight_init(struct device *dev)
-{
- int ret;
-
- ret = gpio_request(S3C64XX_GPF(15), "Backlight");
- if (ret) {
- printk(KERN_ERR "failed to request GPF for PWM-OUT1\n");
- return ret;
- }
-
- /* Configure GPIO pin with S3C64XX_GPF15_PWM_TOUT1 */
- s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_SFN(2));
-
- return 0;
-}
-
-static void smdk6410_backlight_exit(struct device *dev)
-{
- s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_OUTPUT);
- gpio_free(S3C64XX_GPF(15));
-}
-
-static struct platform_pwm_backlight_data smdk6410_backlight_data = {
- .pwm_id = 1,
- .max_brightness = 255,
- .dft_brightness = 255,
- .pwm_period_ns = 78770,
- .init = smdk6410_backlight_init,
- .exit = smdk6410_backlight_exit,
-};
-
-static struct platform_device smdk6410_backlight_device = {
- .name = "pwm-backlight",
- .dev = {
- .parent = &s3c_device_timer[1].dev,
- .platform_data = &smdk6410_backlight_data,
- },
-};
-
static struct map_desc smdk6410_iodesc[] = {};
static struct platform_device *smdk6410_devices[] __initdata = {
--
1.7.2.3
OK, applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Mark Brown wrote:
On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote: quoted On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
[off-list ref] wrote: quoted On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: quoted Remove un-used backlight code for SMDK6410 board quoted quoted Is the data actually wrong? ?If not it'd seem better to finish hooking
it up properly than to remove it. quoted No, this code is no longer needed, as we are having a common backlight
infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're
just deleting unreferenced code.
Yes, I agree with your opinion...It was difficult to know why it is un-used
code when I applied that.
OK, I will amend its commit log in my tree to clear.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Hi Mr. Kim,
On Fri, Aug 19, 2011 at 10:59 AM, Kukjin Kim [off-list ref] wrote: Mark Brown wrote: quoted
On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote: quoted On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
[off-list ref] wrote: quoted On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: quoted Remove un-used backlight code for SMDK6410 board quoted quoted Is the data actually wrong? ?If not it'd seem better to finish hooking
it up properly than to remove it. quoted No, this code is no longer needed, as we are having a common backlight
infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're
just deleting unreferenced code.
Yes, I agree with your opinion...It was difficult to know why it is un-used
code when I applied that. Yes, I will explain more in comments in future!
OK, I will amend its commit log in my tree to clear. Thank you!
Thanks and Regards,
Banajit Goswami
Hi Mark,
On Fri, Aug 19, 2011 at 10:23 AM, Mark Brown
[off-list ref] wrote: On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote: quoted On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
[off-list ref] wrote: quoted On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: quoted Remove un-used backlight code for SMDK6410 board quoted quoted Is the data actually wrong? ?If not it'd seem better to finish hooking
it up properly than to remove it. quoted No, this code is no longer needed, as we are having a common backlight
infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're
just deleting unreferenced code. Thanks.
Will add more description now on.
Thanks and Regards,
Banajit Goswami