[PATCH 07/15] ARM: EXYNOS4: Use generic DMA PL330 driver

Hi Boojin,

On 27 July 2011 11:01, Boojin Kim [off-list ref] wrote:

This patch makes Samsung EXYNOS4 to use DMA PL330 driver
on DMADEVICE. The EXYNOS4 uses DMA generic APIs instead of
SAMSUNG specific S3C-PL330 APIs.

Signed-off-by: Boojin Kim <redacted>
Signed-off-by: Kukjin Kim <redacted>
---
?arch/arm/mach-exynos4/Kconfig | ? ?2 +-
?arch/arm/mach-exynos4/clock.c | ? 16 ++-
?arch/arm/mach-exynos4/dma.c ? | ?299 ++++++++++++++++++++++++++---------------
?3 files changed, 198 insertions(+), 119 deletions(-)

[...]

[...]

+struct amba_device exynos4_device_pdma0 = {
+ ? ? ? .dev = {
+ ? ? ? ? ? ? ? .init_name = "dma-pl330.0",
? ? ? ? ? ? ? ?.dma_mask = &dma_dmamask,
? ? ? ? ? ? ? ?.coherent_dma_mask = DMA_BIT_MASK(32),
? ? ? ? ? ? ? ?.platform_data = &exynos4_pdma0_pdata,
? ? ? ?},
+ ? ? ? .res = {
+ ? ? ? ? ? ? ? .start = EXYNOS4_PA_PDMA0,
+ ? ? ? ? ? ? ? .end = EXYNOS4_PA_PDMA0 + SZ_4K,
+ ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
+ ? ? ? },
+ ? ? ? .irq = {IRQ_PDMA0, NO_IRQ},
+ ? ? ? .periphid = 0x00041330,
?};

[...]

+struct amba_device exynos4_device_pdma1 = {
+ ? ? ? .dev = {
+ ? ? ? ? ? ? ? .init_name = "dma-pl330.1",
? ? ? ? ? ? ? ?.dma_mask = &dma_dmamask,
? ? ? ? ? ? ? ?.coherent_dma_mask = DMA_BIT_MASK(32),
? ? ? ? ? ? ? ?.platform_data = &exynos4_pdma1_pdata,
? ? ? ?},
-};
-
-static struct platform_device *exynos4_dmacs[] __initdata = {
- ? ? ? &exynos4_device_pdma0,
- ? ? ? &exynos4_device_pdma1,
+ ? ? ? .res = {
+ ? ? ? ? ? ? ? .start = EXYNOS4_PA_PDMA1,
+ ? ? ? ? ? ? ? .end = EXYNOS4_PA_PDMA1 + SZ_4K,
+ ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
+ ? ? ? },
+ ? ? ? .irq = {IRQ_PDMA1, NO_IRQ},
+ ? ? ? .periphid = 0x00041330,
?};

?static int __init exynos4_dma_init(void)
?{
- ? ? ? platform_add_devices(exynos4_dmacs, ARRAY_SIZE(exynos4_dmacs));
+ ? ? ? amba_device_register(&exynos4_device_pdma0, &iomem_resource);

How would the 'exynos4_device_pdma1' instance get registered? Should
there be a amba_device_register call for 'exynos4_device_pdma1'
instance as well?

Thanks,
Thomas.