Thread (44 messages) flat view 44 messages, 10 authors, 2011-08-25
STALE5464d

[PATCH 13/15] spi/s3c64xx: Merge dma control code

From: jassisinghbrar@gmail.com (Jassi Brar)
Date: 2011-08-08 18:32:37
Also in: linux-samsung-soc

On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim [off-list ref] wrote:
This patch modifies to merge the dma control code.
Original s3c64xx spi driver has each dma control code for rx and tx channel.
This patch merges these dma control codes into one.
With this patch, a dma setup function and callback function handle
for both rx and tx channel.
This is nothing really to do with underlying DMAENGINE API.
And, apparently it actually bloats the driver ?   76 insertions(+), 64
deletions(-)
Yet, I am not very against the idea.

If you must do it, maybe It would have been better to move it early in
the patchset,
which would have resulted in a smaller and cleaner  "spi/s3c64xx: Add
support DMA engine API"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help