[PATCH v3] new helper to define common struct resource constructs
From: Lothar Waßmann <hidden>
Date: 2011-07-14 11:35:21
Also in:
lkml
Hi, Uwe Kleine-K?nig writes:
quoted hunk ↗ jump to hunk
resource definitions that just define start, end and flags = IORESOURCE_MEM or IORESOURCE_IRQ (with start=end) are quite common. So introduce a shortcut for them. For completeness add macros for IORESOURCE_DMA and IORESOURCE_IO, too and also make available a set of macros to specify named resources of all types which are less common. Signed-off-by: Uwe Kleine-K?nig <redacted> --- changes since v2: - add parentheses around macro parameter usages changes since v1: - also add _IO and _DMA variants include/linux/ioport.h | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-)diff --git a/include/linux/ioport.h b/include/linux/ioport.h index 63eb429..9d57a71 100644 --- a/include/linux/ioport.h +++ b/include/linux/ioport.h@@ -109,6 +109,36 @@ struct resource_list { /* PCI control bits. Shares IORESOURCE_BITS with above PCI ROM. */ #define IORESOURCE_PCI_FIXED (1<<4) /* Do not move resource */ + +/* helpers to define resources */ +#define DEFINE_RES_NAMED(_start, _size, _name, _flags) \ + { \ + .start = (_start), \ + .end = (_start) + (_size) - 1, \ + .name = (_name), \ + .flags = (_flags), \ + } + +#define DEFINE_RES_IO_NAMED(_start, _size, _name) \ + DEFINE_RES_NAMED((_start), (_size), (_name), IORESOURCE_IO)
There is no need for parens around a macro argument when it is not part of an expression... This just looks silly. Lothar Wa?mann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________