Hello.

Artem Bityutskiy wrote:

quoted

quoted

quoted

quoted

In the process of moving platforms away from integrator-flash
(aka armflash), add to physmap the few features that make
armflash unique:
- optionnal probing for the AFS partition type
- init() and exit() methods, used by Integrator to control
  write access to the various onboard programmable components
Signed-off-by: Marc Zyngier <redacted>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Woodhouse <dwmw2@infradead.org>

[...]

quoted

quoted

quoted

quoted

diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h
index bcfd9f7..d37cca0 100644
--- a/include/linux/mtd/physmap.h
+++ b/include/linux/mtd/physmap.h

@@ -22,6 +22,8 @@ struct map_info;

 struct physmap_flash_data {
    unsigned int            width;
+   int                     (*init)(struct platform_device *);
+   void                    (*exit)(struct platform_device *);

    How about a declaration for 'struct platform_device' beforehand? This breaks
build on other platforms at least...

quoted

quoted

Sure. Please send a patch.

quoted

uhh, what ?  you broke things, so you fix them.  i already pointed out
this breakage to you over a week ago.
-mike

The change went in via Russell's tree, I sent him a fix. It looks like
he did not merge it.

    Russell doesn't merge patches sent to him AFAIK, they need to be put into 
his patch system first.

WBR, Sergei