On Tue, May 31, 2011 at 17:44, Marc Zyngier wrote:

On Tue, 31 May 2011 23:11:14 +0400 Sergei Shtylyov wrote:

quoted

Marc Zyngier wrote:

quoted

In the process of moving platforms away from integrator-flash
(aka armflash), add to physmap the few features that make
armflash unique:

quoted

- optionnal probing for the AFS partition type
- init() and exit() methods, used by Integrator to control
? write access to the various onboard programmable components

quoted

Signed-off-by: Marc Zyngier <redacted>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Woodhouse <dwmw2@infradead.org>

[...]

quoted

diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h
index bcfd9f7..d37cca0 100644
--- a/include/linux/mtd/physmap.h
+++ b/include/linux/mtd/physmap.h

@@ -22,6 +22,8 @@ struct map_info;

?struct physmap_flash_data {
? ? unsigned int ? ? ? ? ? ?width;
+ ? int ? ? ? ? ? ? ? ? ? ? (*init)(struct platform_device *);
+ ? void ? ? ? ? ? ? ? ? ? ?(*exit)(struct platform_device *);

? ? How about a declaration for 'struct platform_device' beforehand? This breaks
build on other platforms at least...

Sure. Please send a patch.

uhh, what ?  you broke things, so you fix them.  i already pointed out
this breakage to you over a week ago.
-mike