Thread (11 messages) flat view 11 messages, 4 authors, 2011-06-21

[PATCH 1/2] config: omap2+: force fb and dss support as built-in

From: Premi, Sanjeev <hidden>
Date: 2011-06-20 12:07:34
Also in: linux-fbdev, lkml

quoted hunk ↗ jump to hunk
-----Original Message-----
From: linux-omap-owner at vger.kernel.org 
[mailto:linux-omap-owner at vger.kernel.org] On Behalf Of Tushar Behera
Sent: Monday, June 20, 2011 4:16 PM
To: linux-kernel at vger.kernel.org; 
linux-arm-kernel at lists.infradead.org; 
linux-fbdev at vger.kernel.org; linux-omap at vger.kernel.org
Cc: linux at arm.linux.org.uk; tony at atomide.com; 
lethal at linux-sh.org; linaro-dev at lists.linaro.org; 
patches at linaro.org; Nilofer, Samreen
Subject: [PATCH 1/2] config: omap2+: force fb and dss support 
as built-in

In certain board files, there are references to vram related functions
which are defined in drivers/video/omap2/vram.c. Because of 
this direct
dependency, CONFIG_FB_OMAP2 should be a built-in feature.

As per the current architecture, CONFIG_FB_OMAP2 is dependent on
CONFIG_OMAP2_DSS. Hence CONFIG_OMAP2_DSS support should also 
be selected
by default.

Cc: Tony Lindgren <tony@atomide.com>
Cc: Samreen <redacted>
Signed-off-by: Tushar Behera <redacted>
---
arch/arm/mach-omap2/built-in.o: In function `rx51_video_mem_init':
linux-linaro-2.6.39/arch/arm/mach-omap2/board-rx51-video.c:97:
 undefined reference to `omap_vram_set_sdram_vram'
arch/arm/plat-omap/built-in.o: In function `omap_reserve':
linux-linaro-2.6.39/arch/arm/plat-omap/common.c:66: undefined 
reference to `omap_vram_reserve_sdram_memblock'
arch/arm/plat-omap/built-in.o: In function `omap_detect_sram':
linux-linaro-2.6.39/arch/arm/plat-omap/sram.c:179: undefined 
reference to `omap_vram_reserve_sram'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [sub-make] Error 2

 arch/arm/configs/omap2plus_defconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/configs/omap2plus_defconfig 
b/arch/arm/configs/omap2plus_defconfig
index d5f00d7..c3ffff2 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -138,11 +138,11 @@ CONFIG_FIRMWARE_EDID=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_FB_TILEBLITTING=y
 CONFIG_FB_OMAP_LCD_VGA=y
-CONFIG_OMAP2_DSS=m
+CONFIG_OMAP2_DSS=y
 CONFIG_OMAP2_DSS_RFBI=y
 CONFIG_OMAP2_DSS_SDI=y
 CONFIG_OMAP2_DSS_DSI=y
-CONFIG_FB_OMAP2=m
+CONFIG_FB_OMAP2=y
 CONFIG_PANEL_GENERIC_DPI=m
 CONFIG_PANEL_SHARP_LS037V7DW01=m
 CONFIG_PANEL_NEC_NL8048HL11_01B=m

[sp] Instead of changing the omap2plus_defconfig, shouldn't the
     board specific file be fixed instead?

~sanjeev
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe 
linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help