[PATCH v5 15/19] ARM: LPAE: Add support for cpu_v7_do_(suspend|resume)

On 20 May 2011 19:09, Nicolas Pitre [off-list ref] wrote:

On Fri, 20 May 2011, Catalin Marinas wrote:

quoted

On Wed, 2011-05-18 at 08:27 +0100, Tony Lindgren wrote:

quoted

Do we really need all this ifdef else throughout this series?

I think we already have things in place to do this dynamically
like we already do for thumb, smp_on_up, v6 vs v7 and so on.

By dynamically, do you mean at run-time? We won't be able to compile
both classic and LPAE in the same kernel, there is just too much
difference between them (2 vs 3 levels of page tables - LPAE is an
entirely new format).

If you mean some simpler macros like what we have for ARM/THUMB to
reduce the number of lines, I'm fine with it though we don't always have
a 1:1 mapping between LPAE and non-LPAE instructions.

Alternatively, I'm happy to create a separate proc-v7lpae.S file.

That would probably be the best option.

OK, I'll move this code to a separate file. The v7 setup code got
pretty hard to read.

-- 
Catalin