[PATCH 1/4] drivers: create a pinmux subsystem

2011/5/11 Joe Perches [off-list ref]:

On Wed, 2011-05-11 at 00:18 +0200, Linus Walleij wrote:

quoted

2011/5/2 Joe Perches [off-list ref]:

quoted

On Mon, 2011-05-02 at 21:16 +0200, Linus Walleij wrote:

quoted

From: Linus Walleij <redacted>

diff --git a/drivers/pinmux/core.c b/drivers/pinmux/core.c

Trivial comments follow

quoted

+static inline int pin_is_valid(int pin)
+{
+ ? ? return ((unsigned)pin) < MACH_NR_PINS;
+}

Couldn't pin just be declared unsigned or maybe u32?

No, because like in the GPIO subsystem you *may* want to send in invalid
pins, and those are identified by negative numbers.

Then I think this is clearer and the compiler
should produce the same code.

static inline bool pin_is_valid(int pin)
{
? ? ? ?return pin >= 0 && pin < MACH_NR_PINS;
}

Yes indeed, I'll fix. Can you propose a patch to the same pattern
found in include/asm-generic/gpio.h? It would bring equal
clarity there I believe.

Thanks!
Linus Walleij