[PATCH v4 1/3] ARM: S5P: Add s5p_timer support for HRT

Jamie Iles wrote:

Hi,

Hi Jamie,

On Thu, Mar 10, 2011 at 01:48:22PM +0900, Sangbeom Kim wrote:

quoted

And Do you mean that Is needed error handling of clk_enable  like
below?

	clk_enable(timerclk);

	if (IS_ERR(timerclk)){
		clk_put(timerclk)
		panic("failed to enable timers clock");
	}

No, clk_enable() returns negative errno on failure, so something like.

	if (clk_enable(timerclk))
		panic("failed to enable timerclk");

Thanks for your suggestion.

Yeah, would be better...but I'm thinking we _really_ need that.
Because it is used timer clock, so if fails, maybe happened hang :(

quoted

There is no another clk_enable for timerclk.

I didn't mean for just timerclk, there are several other clk_enable()'s
for other clks.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.