Thread (9 messages) flat view 9 messages, 3 authors, 2011-03-11
STALE5638d

Revision v4 of 7 in this series.

Revisions (7)
  1. v2 [diff vs current]
  2. v2 [diff vs current]
  3. v2 [diff vs current]
  4. v4 [diff vs current]
  5. v4 [diff vs current]
  6. v4 [diff vs current]
  7. v4 current

[PATCH v4 1/3] ARM: S5P: Add s5p_timer support for HRT

From: Jamie Iles <hidden>
Date: 2011-03-10 09:49:41
Also in: linux-samsung-soc

Hi,

On Thu, Mar 10, 2011 at 01:48:22PM +0900, Sangbeom Kim wrote:
And Do you mean that Is needed error handling of clk_enable  like 
below?

	clk_enable(timerclk);

	if (IS_ERR(timerclk)){
		clk_put(timerclk)
		panic("failed to enable timers clock");
	}
No, clk_enable() returns negative errno on failure, so something like.

	if (clk_enable(timerclk))
		panic("failed to enable timerclk");
There is no another clk_enable for timerclk.
I didn't mean for just timerclk, there are several other clk_enable()'s 
for other clks.

Jamie
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help