[PATCH v2] ARM: EXYNOS4: enabled lcd and backlight in NURI board

 Thank you for your comments.
I had answer below and will fix it along your comments.

On 2011-03-07, Kukjin Kim wrote:

Donghwa Lee wrote:

quoted

This patch enables lcd and backlight drivers in NURI board.

Signed-off-by: Donghwa Lee <redacted>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
Changes since v1:
- Adds backlight platform data to control brightness and GPIO
- Modify inappropriate function name and remove useless codes.
- And so on.

 arch/arm/mach-exynos4/Kconfig     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c |   81
+++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+), 0 deletions(-)

Thanks for re-work :)
There are small comments below.

(snip)

quoted

+static void nuri_lcd_power_on(struct plat_lcd_data *pd, unsigned int

power)

quoted

+{
+	int gpio = EXYNOS4_GPE1(5);
+
+	if (power)
+		gpio_direction_output(gpio, 1);
+	else
+		gpio_direction_output(gpio, 0);

	gpio_direction_output(gpio, power);

Ok, I will fix it.

quoted

+}
+
+static int nuri_bl_init(struct device *dev)
+{
+	int ret, gpio = EXYNOS4_GPE2(3);
+
+	ret = gpio_request(gpio, "LCD_LDO_EN");
+	if (!ret)
+		gpio_direction_output(gpio, 0);
+
+	return 0;

	return ret;

I will fix it.

quoted

+}

(snip)

quoted

+static struct platform_device nuri_lcd_device = {
+	.name			= "platform-lcd",
+	.id			= -1,
+	.dev			= {
+		.platform_data	= (void *) &nuri_lcd_platform_data,

		.platform_data = &nuri_lcd_platform_data,

quoted

+	},
+};

I will fix it.

(snip)

You used gpio_request() for EXYNOS4_GPE2(3) and EXYNOS4_GPE1(5), but
EXYNOS4_GPE1(5). Is there any reason or policy for it?

You mean why I left out the gpio_free() after gpio_request(), right?
There was my mistake, I will add it.

Thank you,
Donghwa Lee