[PATCH v2] ARM: EXYNOS4: enabled lcd and backlight in NURI board

This patch enables lcd and backlight drivers in NURI board.

Signed-off-by: Donghwa Lee <redacted>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
Changes since v1:
- Adds backlight platform data to control brightness and GPIO
- Modify inappropriate function name and remove useless codes.
- And so on.

 arch/arm/mach-exynos4/Kconfig     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c |   81 +++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index 5bf00b9..de31e4d 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig

@@ -135,6 +135,7 @@ config MACH_NURI
 	select EXYNOS4_SETUP_I2C1
 	select EXYNOS4_SETUP_I2C5
 	select EXYNOS4_SETUP_SDHCI
+	select SAMSUNG_DEV_PWM
 	help
 	  Machine support for Samsung Mobile NURI Board.
 

diff --git a/arch/arm/mach-exynos4/mach-nuri.c b/arch/arm/mach-exynos4/mach-nuri.c
index 28010bd..d19aed0 100644
--- a/arch/arm/mach-exynos4/mach-nuri.c
+++ b/arch/arm/mach-exynos4/mach-nuri.c

@@ -17,6 +17,10 @@
 #include <linux/regulator/machine.h>
 #include <linux/regulator/fixed.h>
 #include <linux/mmc/host.h>
+#include <linux/fb.h>
+#include <linux/pwm_backlight.h>
+
+#include <video/platform_lcd.h>
 
 #include <asm/mach/arch.h>
 #include <asm/mach-types.h>

@@ -181,6 +185,79 @@ static struct platform_device nuri_gpio_keys = {
 	},
 };
 
+static void nuri_lcd_power_on(struct plat_lcd_data *pd, unsigned int power)
+{
+	int gpio = EXYNOS4_GPE1(5);
+
+	if (power)
+		gpio_direction_output(gpio, 1);
+	else
+		gpio_direction_output(gpio, 0);
+}
+
+static int nuri_bl_init(struct device *dev)
+{
+	int ret, gpio = EXYNOS4_GPE2(3);
+
+	ret = gpio_request(gpio, "LCD_LDO_EN");
+	if (!ret)
+		gpio_direction_output(gpio, 0);
+
+	return 0;
+}
+
+static int nuri_bl_notify(struct device *dev, int brightness)
+{
+	if (brightness < 1)
+		brightness = 1;
+
+	gpio_set_value(EXYNOS4_GPE2(3), 1);
+
+	return brightness;
+}
+
+static void nuri_bl_exit(struct device *dev)
+{
+	gpio_free(EXYNOS4_GPE2(3));
+}
+
+/* nuri pwm backlight */
+static struct platform_pwm_backlight_data nuri_backlight_data = {
+	.pwm_id			= 0,
+	.pwm_period_ns		= 30000,
+	.max_brightness		= 100,
+	.dft_brightness		= 50,
+	.init			= nuri_bl_init,
+	.notify			= nuri_bl_notify,
+	.exit			= nuri_bl_exit,
+};
+
+static struct platform_device nuri_backlight_device = {
+	.name			= "pwm-backlight",
+	.id			= -1,
+	.dev			= {
+		.parent		= &s3c_device_timer[0].dev,
+		.platform_data	= &nuri_backlight_data,
+	},
+};
+
+static struct plat_lcd_data nuri_lcd_platform_data = {
+	.set_power		= nuri_lcd_power_on,
+};
+
+static struct platform_device nuri_lcd_device = {
+	.name			= "platform-lcd",
+	.id			= -1,
+	.dev			= {
+		.platform_data	= (void *) &nuri_lcd_platform_data,
+	},
+};
+
+static void __init nuri_fb_init(void)
+{
+	gpio_request(EXYNOS4_GPE1(5), "LVDS_nSHDN");
+}
+
 /* I2C1 */
 static struct i2c_board_info i2c1_devs[] __initdata = {
 	/* Gyro, To be updated */

@@ -201,8 +278,11 @@ static struct platform_device *nuri_devices[] __initdata = {
 	&s3c_device_wdt,
 #endif
 
+	&s3c_device_timer[0],
 	/* NURI Devices */
 	&nuri_gpio_keys,
+	&nuri_lcd_device,
+	&nuri_backlight_device,
 };
 
 static void __init nuri_map_io(void)

@@ -219,6 +299,7 @@ static void __init nuri_machine_init(void)
 	i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs));
 	i2c_register_board_info(5, i2c5_devs, ARRAY_SIZE(i2c5_devs));
 
+	nuri_fb_init();
 	/* Last */
 	platform_add_devices(nuri_devices, ARRAY_SIZE(nuri_devices));
 }

-- 
1.6.0.4

Donghwa Lee wrote:

This patch enables lcd and backlight drivers in NURI board.

Signed-off-by: Donghwa Lee <redacted>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
Changes since v1:
- Adds backlight platform data to control brightness and GPIO
- Modify inappropriate function name and remove useless codes.
- And so on.

 arch/arm/mach-exynos4/Kconfig     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c |   81
+++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+), 0 deletions(-)

Thanks for re-work :)
There are small comments below.

(snip)

+static void nuri_lcd_power_on(struct plat_lcd_data *pd, unsigned int

power)

+{
+	int gpio = EXYNOS4_GPE1(5);
+
+	if (power)
+		gpio_direction_output(gpio, 1);
+	else
+		gpio_direction_output(gpio, 0);

	gpio_direction_output(gpio, power);

+}
+
+static int nuri_bl_init(struct device *dev)
+{
+	int ret, gpio = EXYNOS4_GPE2(3);
+
+	ret = gpio_request(gpio, "LCD_LDO_EN");
+	if (!ret)
+		gpio_direction_output(gpio, 0);
+
+	return 0;

	return ret;

+}

(snip)

+static struct platform_device nuri_lcd_device = {
+	.name			= "platform-lcd",
+	.id			= -1,
+	.dev			= {
+		.platform_data	= (void *) &nuri_lcd_platform_data,

		.platform_data = &nuri_lcd_platform_data,

+	},
+};

(snip)

You used gpio_request() for EXYNOS4_GPE2(3) and EXYNOS4_GPE1(5), but
EXYNOS4_GPE1(5). Is there any reason or policy for it?


Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

 Thank you for your comments.
I had answer below and will fix it along your comments.

On 2011-03-07, Kukjin Kim wrote:

Donghwa Lee wrote:

quoted

This patch enables lcd and backlight drivers in NURI board.

Signed-off-by: Donghwa Lee <redacted>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
Changes since v1:
- Adds backlight platform data to control brightness and GPIO
- Modify inappropriate function name and remove useless codes.
- And so on.

 arch/arm/mach-exynos4/Kconfig     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c |   81
+++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+), 0 deletions(-)

Thanks for re-work :)
There are small comments below.

(snip)

quoted

+static void nuri_lcd_power_on(struct plat_lcd_data *pd, unsigned int

power)

quoted

+{
+	int gpio = EXYNOS4_GPE1(5);
+
+	if (power)
+		gpio_direction_output(gpio, 1);
+	else
+		gpio_direction_output(gpio, 0);

	gpio_direction_output(gpio, power);

Ok, I will fix it.

quoted

+}
+
+static int nuri_bl_init(struct device *dev)
+{
+	int ret, gpio = EXYNOS4_GPE2(3);
+
+	ret = gpio_request(gpio, "LCD_LDO_EN");
+	if (!ret)
+		gpio_direction_output(gpio, 0);
+
+	return 0;

	return ret;

I will fix it.

quoted

+}

(snip)

quoted

+static struct platform_device nuri_lcd_device = {
+	.name			= "platform-lcd",
+	.id			= -1,
+	.dev			= {
+		.platform_data	= (void *) &nuri_lcd_platform_data,

		.platform_data = &nuri_lcd_platform_data,

quoted

+	},
+};

I will fix it.

(snip)

You used gpio_request() for EXYNOS4_GPE2(3) and EXYNOS4_GPE1(5), but
EXYNOS4_GPE1(5). Is there any reason or policy for it?

You mean why I left out the gpio_free() after gpio_request(), right?
There was my mistake, I will add it.

Thank you,
Donghwa Lee